Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): new builder paging control component #21

Closed
wants to merge 1 commit into from

Conversation

tnadkarni2
Copy link
Contributor

No description provided.

@tnadkarni2 tnadkarni2 requested a review from a team as a code owner September 30, 2024 23:41
@ashmc
Copy link
Contributor

ashmc commented Oct 1, 2024

@tnadkarni2 can you also update the README table to include this new component please, and you are missing adding your custom labels to the labels folder

* @param {Event} event The event object
*/
handlePaginationPage(event) {
let pageNumber = parseInt(event.target.value, 10);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be const

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of warnings flagged by the GH actions that should also be heeded.

@seckardt
Copy link
Collaborator

seckardt commented Oct 1, 2024

@tnadkarni2 Have you also verified that pushing the custom code to an org as well as using the component in Experience Builder works?

@tnadkarni2
Copy link
Contributor Author

tnadkarni2 commented Oct 4, 2024

@seckardt @ashmc I have created a new PR for the builder component #22
Tested the component in the experience bundle and its working as expected. I will close this PR

@tnadkarni2 tnadkarni2 closed this Oct 4, 2024
@tnadkarni2 tnadkarni2 deleted the feature/newBuilderPagingControl branch October 5, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants